Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet 8 #293

Merged
merged 7 commits into from
Nov 23, 2023
Merged

dotnet 8 #293

merged 7 commits into from
Nov 23, 2023

Conversation

hahn-kev
Copy link
Collaborator

dotnet 8 is currently on an RC, I'd like to try to keep this up to date so we can update as soon as it gets released in November.

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

C# Unit Tests

36 tests  +2   36 ✔️ +2   5s ⏱️ -9s
  7 suites +1     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit 1773b99. ± Comparison against base commit 06a610c.

♻️ This comment has been updated with latest results.

@hahn-kev hahn-kev force-pushed the dotnet-8 branch 2 times, most recently from f9c7025 to 970b888 Compare October 10, 2023 03:59
@hahn-kev
Copy link
Collaborator Author

may be blocked by sillsdev/chorus#327, it may be possible to work around the issue, but I'd rather not as BinaryFormatter should no longer be used.

@rmunn
Copy link
Contributor

rmunn commented Nov 15, 2023

Dotnet 8 has been officially released now.

Copy link
Contributor

@rmunn rmunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some NuGet package versions can be bumped to official releases instead of preview versions, then go ahead and merge this. I've tested it on my machine and it works just fine.

backend/LexBoxApi/LexBoxApi.csproj Outdated Show resolved Hide resolved
backend/LexBoxApi/LexBoxApi.csproj Outdated Show resolved Hide resolved
backend/LexData/LexData.csproj Outdated Show resolved Hide resolved
backend/Testing/Testing.csproj Outdated Show resolved Hide resolved
Copy link

UI unit Tests

1 tests   1 ✔️  0s ⏱️
1 suites  0 💤
1 files    0

Results for commit 1773b99.

…ms, fix bug where forgot password would not authenticate because of duplicate jti claims
@hahn-kev hahn-kev marked this pull request as ready for review November 22, 2023 02:05
@hahn-kev hahn-kev merged commit 31b82cd into develop Nov 23, 2023
@hahn-kev hahn-kev deleted the dotnet-8 branch July 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants